feat: add sortBy functionality to 'My Courses' for students (#1044)#793
Open
josefacastillo wants to merge 2 commits intomainfrom
Open
feat: add sortBy functionality to 'My Courses' for students (#1044)#793josefacastillo wants to merge 2 commits intomainfrom
josefacastillo wants to merge 2 commits intomainfrom
Conversation
| const { t } = useTranslation(); | ||
| const navigate = useNavigate(); | ||
| const [sortedCourses, setSortedCourses] = useState({ | ||
| current: currentCourses, |
Member
There was a problem hiding this comment.
This does not reflect changes if the outer component passed in different courses. I think it would be better to add a state for the dropdown and do the sort in a memo:
const [sortOrder, setSortOrder] = useState('updated');
const sortedCourses = useMemo(() => {
// ...
}, [courses, sortOrder]);
JeangelLF
reviewed
Mar 3, 2025
Contributor
JeangelLF
left a comment
JeangelLF
left a comment
There was a problem hiding this comment.
Thanks for the PR! 🙌 Let me know if you need any help with the translations :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/corona-school/project-user/issues/1044
Added a Select Component to 'My Courses' section for Students which can sort by 'updatedAt' and 'nextLecture.start', for current, drafted and past Courses.
We could extend this to every course overview.
TODO: add translation to missing languages: turkish, ukranian, arabic, russian.