Drop in-built support for bitnami's memcached #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: relusc <[email protected]>
relusc
force-pushed
the
removeBitnamiReferences
branch
from
1711511 to
7d05142
Compare
nschad
requested changes
Oct 20, 2025
Signed-off-by: relusc <[email protected]>
nschad
changed the title
Signed-off-by: relusc <[email protected]>
Signed-off-by: relusc <[email protected]>
nschad
approved these changes
Oct 20, 2025
kd7lxl
reviewed
Oct 20, 2025
Signed-off-by: relusc <[email protected]>
You can also add CLI Flags via the already existing |
|
i am fine with both, however for me as a user i'd rather have these extra opts. but that's just my personal opinion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Removes all references to bitnami images and subcharts (namely memcached). The plan would be to not be able to install memcached by default since cortex can run without it. The deployment of memcached is up to the cortex user and is not in the responsibility of the chart anymore.
Which issue(s) this PR fixes:
It doesn't really fix an issue, but it relates to #548
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX],[DEPENDENCY]