change to check tenant limit validation only for some targets #6880
Conversation
pkg/cortex/runtime_config.go
Outdated
| if err := ul.Validate(l.cfg.Distributor.ShardByAllLabels, l.cfg.Ingester.ActiveSeriesMetricsEnabled); err != nil { | ||
| return nil, err | ||
| targetStr := l.cfg.Target.String() | ||
| if strings.Contains(targetStr, All) || strings.Contains(targetStr, Distributor) || strings.Contains(targetStr, Querier) { |
There was a problem hiding this comment.
@SungJin1212 Is querier here because it also use the shardByLabes to get user shard and query? Should we add ruler as well as it does the same?
There was a problem hiding this comment.
@danielblando
This is due to docs. The user only enables -distributor.shard-by-all-labels to the distributor and the querier. Then the other components would fail.
There was a problem hiding this comment.
It is required in querier for
cortex/pkg/distributor/query.go
Line 103 in 960b372
As @danielblando mentioned we need to also include Ruler as Ruler is basically distributor + querier. We should also update the doc to mention that.
There was a problem hiding this comment.
@danielblando @yeya24
I updated both PR and Docs. Thanks for the comments!
SungJin1212
force-pushed
the
Skip-runtime-config-load-validation
branch
2 times, most recently
from
9e127cb to
03f8e2a
Compare
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Skip-runtime-config-load-validation
branch
from
03f8e2a to
f7dcba4
Compare
…roject#6880) Signed-off-by: SungJin1212 <[email protected]>
This PR changes to check tenant limit validation when loading runtime config only for
all,distributor,querier, andrulertargets. Without this, the other components could fail when the-distributor.shard-by-all-labelsis false.Which issue(s) this PR fixes:
Fixes #6741
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]