-
Notifications
You must be signed in to change notification settings - Fork 823
Add support for /api/v1/format_query API #6893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add support for /api/v1/format_query API #6893
Conversation
Signed-off-by: Siddarth Gundu <[email protected]>
Signed-off-by: Siddarth Gundu <[email protected]>
Thanks for the contribution. Do we have to require the |
This API is for PromQL pretty-formatting, I'm just wondering if the |
I see, I went through some documentation and based on Prometheus security what I understand is that a standalone prometheus server dosent need any auth because its presumed that untrusted users have access to the Prometheus HTTP endpoint but when cortex acts as a prometheus web server it would still look for Apologies for any confusion I caused |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siddarth2810 This looks good, but needs an integration test. Can you add it?
I believe auth is handled already. The integration test will prove it. |
What this PR does:
The PR enables /api/v1/format_query API endpoint for formatting queries on Query Frontend and Querier
Which issue(s) this PR fixes:
Fixes #6670
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]