Parquet Store gateway #7046
Open
Parquet Store gateway #7046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SungJin1212
force-pushed
the
parquet-gateway-poc
branch
7 times, most recently
from
27d4ca3 to
7ab5bc7
Compare
yeya24
reviewed
Oct 19, 2025
docs/blocks-storage/store-gateway.md
Outdated
| # Minimum time to wait for ring stability at startup. 0 to disable. | ||
| # CLI flag: -store-gateway.sharding-ring.wait-stability-min-duration | ||
| [wait_stability_min_duration: <duration> | default = 1m] | ||
| [wait_stability_min_duration: <duration> | default = 0s] |
There was a problem hiding this comment.
This change should be removed
docs/blocks-storage/store-gateway.md
Outdated
| # start anyway. | ||
| # CLI flag: -store-gateway.sharding-ring.wait-stability-max-duration | ||
| [wait_stability_max_duration: <duration> | default = 5m] | ||
| [wait_stability_max_duration: <duration> | default = 5s] |
There was a problem hiding this comment.
This change should be removed
| assert.Empty(t, warnings) | ||
| } | ||
|
|
||
| //func TestParquetBucketStores_Series_ShouldNotCheckMaxInflightRequestsIfTheLimitIsDisabled(t *testing.T) { |
| assert.Equal(t, codes.InvalidArgument, s.Code()) | ||
| } | ||
|
|
||
| func TestChunkToStoreEncoding(t *testing.T) { |
There was a problem hiding this comment.
This test seems irrelevant?
integration/parquet_gateway_test.go
Outdated
| cortex_testutil "github.com/cortexproject/cortex/pkg/util/test" | ||
| ) | ||
|
|
||
| func TestParquetGatewayWithBlocksStorageRunningInMicroservicesMode(t *testing.T) { |
There was a problem hiding this comment.
I would prefer reusing the existing store gateway integration test instead of creating a new parquet gateway test. This adds a lot of duplicated code
|
@yeya24 |
|
Can u please update the PR title and description? |
SungJin1212
force-pushed
the
parquet-gateway-poc
branch
from
d1c6d11 to
773cfb4
Compare
Signed-off-by: yeya24 <[email protected]>
Signed-off-by: SungJin1212 <[email protected]>
Signed-off-by: SungJin1212 <[email protected]>
Signed-off-by: SungJin1212 <[email protected]>
Signed-off-by: SungJin1212 <[email protected]>
Signed-off-by: SungJin1212 <[email protected]>
Signed-off-by: SungJin1212 <[email protected]>
Signed-off-by: SungJin1212 <[email protected]>
Signed-off-by: SungJin1212 <[email protected]>
Signed-off-by: SungJin1212 <[email protected]>
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
parquet-gateway-poc
branch
from
d0d3dae to
336be55
Compare
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
parquet-gateway-poc
branch
from
336be55 to
553e4ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new parquet mode for the Store Gateway. In this initial version, the mode operates statelessly and does not perform operations such as block syncing. The primary improvement is to enhance cache utilization by leveraging the Store Gateway's block affinity.
Which issue(s) this PR fixes:
Fixes #6940
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]