Add ANCAP Chain: assetlist, logo, chain.json #6297
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancapchainx/assetlist.json
Outdated
| "display": "ANCAP", | ||
| "symbol": "ANCAP", | ||
| "logo_URIs": { | ||
| "png": "https://red-illegal-kangaroo-569.mypinata.cloud/ipfs/bafkreiajtxbe67jbibabet55xmekxl2mw4ietohhpunz66qfwurkffg3tm" |
There was a problem hiding this comment.
Please upload the image here (under /ancapchainx/images) and reference that upload instead. (it likely is the logo.png already uploaded, which just has to go into the proper directory and the URL would point there)
There was a problem hiding this comment.
The URL must reference the mast branch, no your fork. Please update the URL to the correct, required format
ancapchainx/chain.json
Outdated
| "daemon_name": "ancapchainxd", | ||
| "node_home": "$HOME/.ancapchainx", | ||
| "genesis": { | ||
| "genesis_url": "" |
There was a problem hiding this comment.
Please remove empty properties
ancapchainx/chain.json
Outdated
| "genesis_url": "" | ||
| }, | ||
| "logo_URIs": { | ||
| "png": "https://red-illegal-kangaroo-569.mypinata.cloud/ipfs/bafkreiajtxbe67jbibabet55xmekxl2mw4ietohhpunz66qfwurkffg3tm" |
There was a problem hiding this comment.
Same issue with the image URL as mentioned in the assetlist
updated logo.png
updated logo.png
changed logo.png to master
changed logo.png to master
updated git repo
re worked the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds assetlist.json, chain.json, and logo for ANCAP Coin (denom: uancap).