-
Notifications
You must be signed in to change notification settings - Fork 304
fix: nodedb find wrong latest version with partial committed batch #1107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Update CHANGELOG.md cleanup
`BatchWithFlusher` could separate the commit of the same version into multiple batches, when the batches are not persisted atomically, the current latest version method will return an incomplete version and eventually return error in `MutableTree.Load(0)` method.
Warning Rate limit exceeded@yihuang has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 1 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
batch_flusher_test.go
Outdated
) | ||
|
||
type MockDBBatch struct { | ||
dbm.Batch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems they removed dbm.Batch
in https://github.com/cosmos/iavl/pull/955/files#diff-367b87ccd372ceca8c6f2e7157b827b4d469318a6571c0cacc99d54c1bb19089
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to corestore
BatchWithFlusher
could separate the commit of the same version into multiple batches, when the batches are not persisted atomically, the current latest version method will return an incomplete version and eventually return error inMutableTree.Load(0)
method.