Implemented bin average for 1 point statistics #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
It's probably dangerously confusing for the rule here to be different for the 2point and 1point cases. Perhaps we need a configuration option? |
Contributor
Author
|
I agree on this. I can ensure normalisation before, so that part stays the same. The input shape of the weights seem to be the same as for the 2pt, but as we operate on the whole datavector and not individual data points the code needs to broadcast the correct shapes together when multiplying the matrices. But let me check that again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the bin averaging using the SACC weights is implemented. For the specifics of the 1pt statistics the weights are always re-normalised, and the matrix multiplication for evaluation of the average needs to be performed on a 2D weights input.