Updated Top Bar and Dark Mode Button#2683
Updated Top Bar and Dark Mode Button#2683vinayak19th wants to merge 4 commits intocotes2020:masterfrom
Conversation
|
Thanks for the PR. I've decided to keep the button in its current position, so please maintain this modification in your distribution. I believe I have already rejected a similar request in the past. |
Sure, but I still would recommend moving it, especially because it mixes the dark mode with profile links (github, email ,etc) which is non-standard. Also on mobile devices its a pain to access cause you have to pull out the sidebar first. |
|
Hey! @vinayak19th I support you! I personally really like this change. I made just one change in my personal page to swap the dark and light mode since it made more sense for me to have dark mode in the "off" position and light mode in the "on" (like flipping on a light switch). |
Type of change
Description
Added 3 major improvements in the PR:
Images:
New Dark UI Layout

New Dark UI Layout (Dark Mode)

Dependency Changes
No dependency changes needed.
Additional context