Skip to content

Updated Top Bar and Dark Mode Button#2683

Closed
vinayak19th wants to merge 4 commits intocotes2020:masterfrom
vinayak19th:Contribution
Closed

Updated Top Bar and Dark Mode Button#2683
vinayak19th wants to merge 4 commits intocotes2020:masterfrom
vinayak19th:Contribution

Conversation

@vinayak19th
Copy link
Copy Markdown

Type of change

  • New feature (non-breaking change which adds functionality)

Description

Added 3 major improvements in the PR:

  1. Moved the dark mode button from the side bar to the top bar next to the search bar. This position seems more natural.
  2. Changed the dark mode button to a slider.
  3. Added a mechanic where the top bar becomes visible when you scroll up. This is inline with common UI practices and makes it easier to access the search bar and dark mode toggle on most devices.

Images:

New Dark UI Layout
image

New Dark UI Layout (Dark Mode)
image

Layout Mobile Layout Mobile (Dark)
image image

Dependency Changes

No dependency changes needed.

Additional context

@vinayak19th vinayak19th changed the title Contribution Updated Top Bar and Dark Mode Button Mar 19, 2026
@cotes2020
Copy link
Copy Markdown
Owner

Thanks for the PR. I've decided to keep the button in its current position, so please maintain this modification in your distribution. I believe I have already rejected a similar request in the past.

@vinayak19th
Copy link
Copy Markdown
Author

Thanks for the PR. I've decided to keep the button in its current position, so please maintain this modification in your distribution. I believe I have already rejected a similar request in the past.

Sure, but I still would recommend moving it, especially because it mixes the dark mode with profile links (github, email ,etc) which is non-standard. Also on mobile devices its a pain to access cause you have to pull out the sidebar first.

@AlphaHasher
Copy link
Copy Markdown

Hey! @vinayak19th I support you! I personally really like this change. I made just one change in my personal page to swap the dark and light mode since it made more sense for me to have dark mode in the "off" position and light mode in the "on" (like flipping on a light switch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants