Stabilize direct-connections request spec#15
Conversation
|
Owner ping for this maintenance PR: @shyam-cb Requesting review from the manifest-listed owner(s) where GitHub does not already show a pending review request. |
There was a problem hiding this comment.
Code Review
This pull request adds an ORDER BY clause to the SQL query in the direct_connections method of the Airport model to ensure consistent ordering of results. The corresponding request spec has been updated to reflect this alphabetical ordering. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
GET /api/v1/airports/direct-connectionsdeterministic by ordering destination airport codesVerification
bundle exec rspec spec/requests/api/v1bundle exec rails server -p 3001curl http://127.0.0.1:3001/api/v1/airports/direct-connections?destinationAirportCode=JFK&limit=5&offset=0curl http://127.0.0.1:3001/api-docs/index.htmlEvidence
27 examples, 0 failuresABQ, ACC, AMM, AMS, ANU200tutorial-maintenance/runs/ruby-on-rails-quickstart/2026-06-09T0319Z/notes.mdNotes
rswag-ui/ostructwarnings still appear during boot/test but did not block verification