Skip to content

Stabilize direct-connections request spec#15

Open
dex-the-ai wants to merge 1 commit into
mainfrom
dex/direct-connections-order-2026-06-09
Open

Stabilize direct-connections request spec#15
dex-the-ai wants to merge 1 commit into
mainfrom
dex/direct-connections-order-2026-06-09

Conversation

@dex-the-ai

Copy link
Copy Markdown
Contributor

Summary

  • make GET /api/v1/airports/direct-connections deterministic by ordering destination airport codes
  • update the stale request-spec expectation to match the current travel-sample result set for the verified happy path

Verification

  • bundle exec rspec spec/requests/api/v1
  • bundle exec rails server -p 3001
  • curl http://127.0.0.1:3001/api/v1/airports/direct-connections?destinationAirportCode=JFK&limit=5&offset=0
  • curl http://127.0.0.1:3001/api-docs/index.html

Evidence

  • Request spec suite passed with 27 examples, 0 failures
  • Verified the endpoint now returns a stable ordered page beginning ABQ, ACC, AMM, AMS, ANU
  • Verified the generated API docs page responds with HTTP 200
  • tutorial-maintenance/runs/ruby-on-rails-quickstart/2026-06-09T0319Z/notes.md

Notes

  • Previous Dex PR Align Couchbase Ruby options and airline ordering #14 was already merged; this follow-up addresses a remaining stale/non-deterministic request-spec expectation on current travel-sample data
  • Existing rswag-ui / ostruct warnings still appear during boot/test but did not block verification

@dex-the-ai dex-the-ai requested a review from shyam-cb June 9, 2026 04:13
@dex-the-ai

Copy link
Copy Markdown
Contributor Author

Owner ping for this maintenance PR: @shyam-cb

Requesting review from the manifest-listed owner(s) where GitHub does not already show a pending review request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds an ORDER BY clause to the SQL query in the direct_connections method of the Airport model to ensure consistent ordering of results. The corresponding request spec has been updated to reflect this alphabetical ordering. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant