Skip to content

Conversation

@JeffMv
Copy link

@JeffMv JeffMv commented Dec 20, 2018

🚨Please review the guidelines for contributing to this repository.

Proposed changes

Added support for providing credentials from a netrc file on *nix systems.
The code and process has been based on the code of the coursera-dl/coursera-dl repo (which was working and tested few years back) and adapted to provide that login option for edx-dl users.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I agree to contribute my changes under the project's LICENSE
  • I have checked that the unit tests pass locally with my changes
  • I have checked the style of the new code (lint/pep).
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, please explain why you chose
the solution you did and what alternatives you considered, etc.

Reviewers

If you know the person who can review your code please add a @mention.

Code for handling netrc has been adapted from the coursera-dl/coursera-dl repo.
Since login with actual credentials is not allowed, maybe we can add a test that takes the netrc file and its credentials and logs in. The netrc file does not have to be
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 47.955% when pulling 8e58984 on JeffMv:master into 265718c on coursera-dl:master.

@de-code
Copy link

de-code commented May 24, 2021

Seems like a good feature to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants