[LLMTM] Update MultiSim to work with Sage10K#262
Open
HoangGiang93 wants to merge 24 commits intocram2:mainfrom
Open
[LLMTM] Update MultiSim to work with Sage10K#262HoangGiang93 wants to merge 24 commits intocram2:mainfrom
HoangGiang93 wants to merge 24 commits intocram2:mainfrom
Conversation
HoangGiang93
requested review from
LucaKro,
ichumuh and
tomsch420
as code owners
# Conflicts: # test/semantic_digital_twin_test/test_sage_10k/test_loader.py
HoangGiang93
requested review from
AbdelrhmanBassiouny,
Tigul and
sunava
as code owners
Contributor
Author
Removed unused import of WorldEntity from multi_sim.py
LucaKro
requested changes
Apr 13, 2026
| @@ -428,20 +428,27 @@ def create_in_world( | |||
| body.collision = collision | |||
|
|
|||
| if self.place_id in ["floor", "wall"]: | |||
Contributor
There was a problem hiding this comment.
only do the minimal amount on code in the if block. so 1x with world.modify_world(), then the if statement for the connection, and then add_body and add_connection once again
Updated docstring for move_branch method to clarify functionality and warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be merged after #260 and #197