feat: implement passkey authentication#643
Open
naveenkash wants to merge 12 commits intocrbnos:mainfrom
Open
Conversation
- Added support for passkey registration and authentication using WebAuthn. - Introduced new API routes for handling passkey options and verification. - Updated login and profile components to integrate passkey functionality. - Included necessary dependencies for passkey handling in package.json. - Enhanced user experience with passkey sign-in options and management.
- Implemented modal dialogs for editing and confirming deletion of passkeys. - Added logic to handle renaming of passkeys with validation for input fields. - Enhanced user experience by allowing passkey selection and management through a drawer interface. - Updated UI components to support new functionality and improve interaction.
|
@naveenkash is attempting to deploy a commit to the Carbon Team on Vercel. A member of the Team first needs to authorize it. |
naveenkash
commented
Apr 7, 2026
| // and model of the authenticator. We use it to display a friendly name like | ||
| // "iCloud Keychain" instead of a raw credential ID. | ||
| // | ||
| // Source: https://passkeydeveloper.github.io/passkey-authenticator-aaguids/ |
Contributor
Author
There was a problem hiding this comment.
- Refactored passkey authentication and registration logic to use WebAuthnCredential type. - Updated publicKey encoding to use base64url format. - Enhanced error handling for userHandle mismatch and credential state persistence. - Added validation for passkey name length in profile management. - Included @simplewebauthn/types as a dependency in package.json.
barbinbrad
reviewed
Apr 9, 2026
barbinbrad
reviewed
Apr 9, 2026
- Updated .env.example to include passkey as an authentication provider. - Refactored login routes to utilize isAuthProviderEnabled for passkey support. - Implemented passkey authentication options in the API routes. - Enhanced user interface to conditionally display passkey sign-in button based on support. - Added checks for passkey availability in account profile and login components.
0ab4bea to
53d1388
Compare
- Updated @simplewebauthn/browser to version ^13.3.0 in package.json files for both apps (erp and mes). - Added AUTH_PROVIDERS to environment configuration in root.tsx files for both apps. - Updated tool-metadata.json with a new generated timestamp. - Adjusted layout and spacing in account-related components for better UI consistency.
Collaborator
|
This looks sick. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Updated error responses in passkey authentication to provide a consistent message:Sign-in failed. Please try again. for various failure scenarios. - Adjusted user verification requirements in passkey server functions to enforce stricter verification policies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds passkey (WebAuthn) support as a passwordless authentication method. Users can register passkeys secured by Face ID, Touch ID, or their device PIN and use them to sign in instead of a magic link. Passkeys also appear in the browser's native autofill dropdown on the login email field (conditional UI).
Visual Demo (For contributors especially)
compressO-Screen.Recording.2026-04-08.at.2.15.51.PM.mp4
Video Demo (if applicable):
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
registration:
authentication:
Checklist