Bump dependencies#217
Closed
satishlokkoju wants to merge 2 commits intocriteo:masterfrom
satishlokkoju:bump-dependencies
Closed
Bump dependencies#217satishlokkoju wants to merge 2 commits intocriteo:masterfrom satishlokkoju:bump-dependencies
satishlokkoju wants to merge 2 commits intocriteo:masterfrom
satishlokkoju:bump-dependencies
Conversation
This change updates the `requirements.txt` and `requirements-test.txt` files to use `>=` for version constraints instead of `==`, allowing for newer package versions to be installed. This update introduced two issues that have been addressed: 1. A `TypeError` during JSON serialization of numpy's `float32` type. This was resolved by adding a custom `NumpyEncoder` to handle the serialization of numpy types. 2. Tests were creating large artifact files in the project root, causing file size limit errors in the test environment. This was fixed by modifying the tests to use temporary directories for their output and adding the generated file patterns to `.gitignore`.
1. Bumps the package dependencies to allow for newer versions. 2. Upgrades the minimum supported Python version to 3.10. The dependency update from fixed versions to minimum versions (`>=`) in `requirements.txt` and `requirements-test.txt` caused some issues that were addressed: - A `TypeError` during JSON serialization of numpy types was fixed by introducing a custom `NumpyEncoder`. - Tests creating large artifact files were fixed to use temporary directories, and the generated file patterns were added to `.gitignore`. The Python version upgrade involved: - Removing classifiers for Python versions older than 3.10 in `setup.py`. - Removing conditional dependencies for older Python versions in `requirements.txt`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.