try and read MARATHON_USERNAME and MARATHON_PASSWORD for auth info#16
Open
adamdecaf wants to merge 1 commit intocriteo:masterfrom
Open
try and read MARATHON_USERNAME and MARATHON_PASSWORD for auth info#16adamdecaf wants to merge 1 commit intocriteo:masterfrom
adamdecaf wants to merge 1 commit intocriteo:masterfrom
Conversation
Contributor
Author
|
FYI. This doesn't seem to work. I tried with your (@matt-deboer's) go-marathon fork and the latest from upstream, but couldn't get My hunch is there's a case in The problem with them in the url is that it'll show up in logs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems easier to use env vars paired with k8s secrets rather than looping through cli flags.
The existing flags are still supported.