Merged
Conversation
crmne
approved these changes
Mar 24, 2025
Owner
|
Nice and simple PR @redox, thanks. Just fix the linting and I'm ready to merge it. |
redox
force-pushed
the
su/fix-gemini-tools
branch
from
13fa50c to
61802bc
Compare
Contributor
Author
|
done @crmne |
Owner
|
There seems to be some test failures. Make sure to run rubocop and rspec before committing. Have you done |
Contributor
Author
Arg, it was a timezone issue. It should be fixed with 4dad99c
I didn't initially, I'm surprised by Cursor+Rubocop plugin didn't complain about the lint issue - need to check why. The specs were all green on my end 😅 |
Contributor
Author
|
Gosh @crmne this time zone issue is driving me nuts |
Owner
|
@redox just make up a different test. I'd be happy to see this out in the next version. |
redox
force-pushed
the
su/fix-gemini-tools
branch
from
80a5769 to
e72b3ca
Compare
Contributor
Author
I just did 🫡 |
Owner
|
You may need to merge with main before continuing. |
Owner
|
Best tool I've seen btw, it's always right ;) |
Contributor
Author
We should be good now
Yeah 🤘 |
Owner
|
There might be a problem in |
Owner
|
I've made some changes to the pipeline, can you merge |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 92.18% 92.22% +0.04%
==========================================
Files 60 60
Lines 1893 1903 +10
Branches 297 298 +1
==========================================
+ Hits 1745 1755 +10
Misses 148 148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think this breaks when streaming. For instance a tool that is will work: But will break if it is: |
parruda
pushed a commit
to parruda/ruby_llm
that referenced
this pull request
Nov 18, 2025
This fixes crmne#61 ensuring the (Gemini) `function_declarations`'s `parameters` is not set when there are no parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #61 ensuring the (Gemini)
function_declarations'sparametersis not set when there are no parameters.