Fix refresh of Bedrock models and remove some expired credentials from cassettes#89
Merged
crmne merged 3 commits intocrmne:mainfrom Apr 2, 2025
Merged
Fix refresh of Bedrock models and remove some expired credentials from cassettes#89crmne merged 3 commits intocrmne:mainfrom
crmne merged 3 commits intocrmne:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 92.11% 92.11%
=======================================
Files 71 71
Lines 2586 2588 +2
Branches 377 378 +1
=======================================
+ Hits 2382 2384 +2
Misses 204 204 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
crmne
approved these changes
Apr 2, 2025
parruda
pushed a commit
to parruda/ruby_llm
that referenced
this pull request
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
In the process of building #50 I made a couple of mistakes.
Approach
Fix the second issue and then rerun the model refresh tests to fix the first.