Uses the same authentication decorator on all modules#1004
Open
poupounetjoyeux wants to merge 3 commits intocrocodilestick:mainfrom
Open
Uses the same authentication decorator on all modules#1004poupounetjoyeux wants to merge 3 commits intocrocodilestick:mainfrom
poupounetjoyeux wants to merge 3 commits intocrocodilestick:mainfrom
Conversation
Owner
|
Hey, just did a review of this and there are a few issues:
If you can resolve these i'll take another look |
Author
|
Hello @crocodilestick, Thank you to have take the time starting the review! I repushed (and rebase) regarding your comments with a dedicated error handler for KOSync Don't hesitate if you see other things to update |
Add an error handler parameter to generate proper errors on KOSync side
Move functions location and add headers for more reliability Make new require_kosync_enabled method a decorator
Author
|
Hello @crocodilestick I just rebased and deployed it locally, all is OK 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make decarotar name more reliable
Remove some code duplication regarding anonymous check
Makes KOSync using standard decorators