Fix race condition in Duplicate Manager causing UI freeze/crash#1095
Open
cd-dr wants to merge 1 commit intocrocodilestick:mainfrom
Open
Fix race condition in Duplicate Manager causing UI freeze/crash#1095cd-dr wants to merge 1 commit intocrocodilestick:mainfrom
cd-dr wants to merge 1 commit intocrocodilestick:mainfrom
Conversation
The Duplicate Manager experienced race conditions when deleting or merging multiple books, leading to UI freezes and application crashes. Root Cause: - Multiple rapid database commits and cache invalidations per book - Immediate page reload before background operations completed - Conflicting database sessions during cleanup Fix: - Batch cache invalidation to run once after all operations complete - Add skip_cache_invalidation parameter to delete_book_from_table() - Add 800ms delay before page reload to allow cleanup to finish - Remove queued duplicate scan calls (page reload handles refresh) This eliminates database contention and prevents session conflicts during batch operations in the Duplicate Manager. Fixes: DELETE SELECTED and MERGE SELECTED operations in duplicates page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Duplicate Manager experiences race conditions when deleting or merging multiple books, leading to UI freezes and application crashes.
Cause:
Fix:
This eliminates database contention and prevents session conflicts during batch operations in the Duplicate Manager.
Fixes: #1084