feat: Add Shelfmark Search when no search results#923
Open
vathzen wants to merge 2 commits intocrocodilestick:mainfrom
Open
feat: Add Shelfmark Search when no search results#923vathzen wants to merge 2 commits intocrocodilestick:mainfrom
vathzen wants to merge 2 commits intocrocodilestick:mainfrom
Conversation
Author
|
@crocodilestick do you think if this is a valuable feature? I can rebase from main to support 4.x otherwise I can close the PR 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the functionality to search in Shelfmark ( Calibre Web Automated Book Downloader (CWABD) ) when the CWA search returns no results.
Accomplishes this by adding a new config entry
config_use_shelfmarkandconfig_shelfmark_urlwhich can be configured in the admin panel.The Shelfmark url is constructed from guidelines here
This is my first PR in this repo, pretty sure I might have missed a couple steps. Please let me know so that I can fix it.
I also ran
scripts\update_spdx_headers.pyso the number of files changed is huge. Please refer the first commit to view actual code changes for this feat.