Skip to content

Conversation

@CeeJayDK
Copy link
Contributor

@CeeJayDK CeeJayDK commented Jul 1, 2025

Ordnung muss sein

@CeeJayDK
Copy link
Contributor Author

CeeJayDK commented Jul 2, 2025

Maybe @cot6 would like to check that the japanese still works?

@crosire
Copy link
Owner

crosire commented Jul 4, 2025

I'm not sure I see the benefit. Having the translations inline makes it immediately obvious what variable they belong to and you also have the corresponding English text to understand right next to them.

@CeeJayDK
Copy link
Contributor Author

CeeJayDK commented Jul 4, 2025

Inline bloats the effect file, and makes a complete mess for several reasons.

  1. The language text takes up so much space it becomes harder to view the code quickly.
  2. It is not displayed correctly in the Reshade editor and simply displays as ? chars
  3. It makes me .. it's creator, reluctant to update it because it's filled with foreign text I do not understand.

Separating out the languages makes it far neater.
It's even possible to also move the english out, which I'm thinking about.
That's not normally necessary but it has become a wall of text.

To make it even cleaner each language could get it's own file.

Compartmentalizing data (language) from code, makes updating either a simpler task where one only needs to concentrate on one of the two.
Thus it's splits a big messy confusing task up into smaller more manageable tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants