Remove dependency on once_cell and work around windows-gnu LTO issue #913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
force-pushed
the
once-cell
branch
5 times, most recently
from
acda07d to
d28aa13
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 29, 2022
914: 0.8: Prepare for the next release r=taiki-e a=taiki-e Backports #913 and CI-related patches. Changes: - crossbeam-epoch 0.8.11 -> 0.8.12 - Removes the dependency on the `once_cell` crate to restore the MSRV. (#913) - Work around [rust-lang#98302](rust-lang/rust#98302), which causes compile error on windows-gnu when LTO is enabled. (#913) - crossbeam-utils 0.8.11 -> 0.8.12 - Removes the dependency on the `once_cell` crate to restore the MSRV. (#913) - Work around [rust-lang#98302](rust-lang/rust#98302), which causes compile error on windows-gnu when LTO is enabled. (#913) Co-authored-by: Taiki Endo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
once_cellwith our ownOnceLockthat based on unstablestd::sync::OnceLockdue to MSRV issue1.This also fixes #856 due to windows-gnu LTO issue.
Footnotes
The current readme says crossbeam support at least 6 months old compilers, but that is a minimum guarantee and is actually more conservative. ↩