Skip to content

Conversation

maximebuyse
Copy link
Collaborator

This PR addresses part of the feedback in the PR to the upstream repo:

I also added some logging of input value on assertion failures which might also be useful to debug test failures.

@maximebuyse maximebuyse requested a review from W95Psp August 19, 2025 16:02
@maximebuyse
Copy link
Collaborator Author

@W95Psp I am interested in your feedback on this, especially about my implementation using mutex and static for having the same rng everywhere (which is necessary to ensure reproducibility from the seed we log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant