Clean up bmi_cem.c

[mcflugen]

As with #19, I've cleaned up the bmi_cem.c to use a table of variables that lists variable names and metadata.

[Copilot]

Pull Request Overview

This PR cleans up bmi_cem.c by replacing repetitive hard-coded metadata with a centralized table of variable information. The key changes include introducing the VarInfo structure with an array of variable definitions, refactoring getter functions to use the lookup table, and consolidating grid and variable metadata handling.

Comments suppressed due to low confidence (1)

bmi_cem.c:309

• After setting *grid = 2 for matched variable names, the code unconditionally resets *grid to -1 and returns BMI_FAILURE. Consider returning BMI_SUCCESS immediately after setting *grid appropriately to avoid overriding the valid assignment.

*grid = -1;

[Copilot]

Pull Request Overview

Refactors bmi_cem.c to centralize variable metadata in a VarInfo table and simplifies per-variable lookups.

• Adds VarInfo struct and variables[] table with name/units/type/itemsize/location
• Introduces find_variable helper and replaces long if-else chains for type/units/itemsize/location
• Leaves per-variable logic in get_var_grid, get_var_nbytes, and get_value_ptr, still manually matching names

Comments suppressed due to low confidence (1)

bmi_cem.c:21

• [nitpick] The array name variables is very generic. Consider renaming it to something more descriptive like var_info_table or bmi_var_info_list.

const VarInfo variables[] = {

[Copilot]

Add a brief comment above the VarInfo typedef explaining its purpose (e.g. “// VarInfo holds metadata for each BMI variable”).

Suggested change

	// VarInfo holds metadata for each BMI variable, including its name, units, type, size, and location.

[Copilot]

The BMI_MAX_UNITS_NAME macro is intended for unit strings. Use the appropriate max‐length macro for type names (e.g. BMI_MAX_TYPE_NAME) to avoid truncation or confusion.

Suggested change

	strncpy(type, var->type, BMI_MAX_UNITS_NAME);
	strncpy(type, var->type, BMI_MAX_TYPE_NAME);

[Copilot]

The get_var_grid function still hard‐codes a subset of variable names. Consider adding a grid_id field to VarInfo and using find_variable to eliminate this manual matching and keep metadata in one place.

[Copilot]

Similarly, get_var_nbytes duplicates name-based logic to pick size sources. You could extend VarInfo to include grid and size logic (or a callback) to avoid repeating these conditionals.