Just some minor performance improvements and warning fixes#2
Open
FlorianPfaff wants to merge 1 commit intocsdms-contrib:masterfrom
Open
Just some minor performance improvements and warning fixes#2FlorianPfaff wants to merge 1 commit intocsdms-contrib:masterfrom
FlorianPfaff wants to merge 1 commit intocsdms-contrib:masterfrom
Conversation
…matlab editor warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
since I'm currently experimenting with your code with spherical harmonics and made some minor improvements, I just thought I'd as well make them available (considering this github project is public).
Most changes are just fixes for Matlab editor warnings for reducing the use of defval. Some additional notes:
Greetings,
Florian