updated docker-compose to make building container easier#923
Open
aravindkoneru wants to merge 1 commit intoct-Open-Source:developmentfrom
Open
updated docker-compose to make building container easier#923aravindkoneru wants to merge 1 commit intoct-Open-Source:developmentfrom
aravindkoneru wants to merge 1 commit intoct-Open-Source:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think having the option to build the containers from docker-compose is cleaner than having to build the base image with docker and then referencing it in docker-compose.yaml. Since the instructions in the readme already require the user to copy docker-compose.sample.yaml to the root directory, it makes sense to allow people to build and run the container using just one command:
docker-compose run tuya start.