Skip to content

Sort runsummary df before the assert#1407

Open
aaguasca wants to merge 1 commit intomainfrom
sort_df
Open

Sort runsummary df before the assert#1407
aaguasca wants to merge 1 commit intomainfrom
sort_df

Conversation

@aaguasca
Copy link
Copy Markdown
Collaborator

If runs are removed, the assertion assert(np.allclose(runlist, runsummary['runnumber'])) sometimes fails because the order is not the same, despite having the same number of runs in runlist and runsummary['runnumber']. For example, one can reproduce this error if the data_quality Jupyter Notebook is run selecting all datachecks.

This PR sorts the runsummary before the assertion to make sure the order is the same in both objects.

This PR is ready for review.

Signed-off-by: Arnau Aguasca-Cabot <arnau.aguasca@fqa.ub.edu>
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@aaguasca aaguasca requested a review from moralejo March 19, 2026 07:38
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.16%. Comparing base (abc6d27) to head (cf838fc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1407   +/-   ##
=======================================
  Coverage   85.16%   85.16%           
=======================================
  Files          95       95           
  Lines        9655     9655           
=======================================
  Hits         8223     8223           
  Misses       1432     1432           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant