feat(flightsql-jdbc): Add support for Arrow Flight JDBC driver (#8829)

[vincentditlevinz]

Check List

• Tests have been run in packages where changes made if available
• Linter has been run for changed code
• Tests for the changes have been added if not covered yet
• Docs have been added / updated if required

Issue Reference this PR resolves

[#8829]

[vincentditlevinz]

Sorry for the level of testing, as I said I've followed packages/cubejs-databricks-jdbc-driver as a template and did not find a lot of tests inside, same with the jdbc drivers module. I might try something with testcontainer...

That said, I successfully managed to build a dev docker image and connect to a spice.ai sql engine supporting arrow flight sql jdbc driver using CUBEJS_DB_TYPE=flightsql-jdbc.

The driver download works as shown in this screenshot showing the dev container internal file system:

However I cannot do more than connecting to the database when clicking on the "Data model" folder.

I might have missed something or perhaps a dev container is not full featured ? When I try to see the generated SQL in the playground I see Error: Unknown dbType: flightsql-jdbc, and in container's logs:

[igorlukanin]

Hi @vincentditlevinz 👋 Thanks! I'd suggest that you can you databricks-jdbc as an example and check if there's anything else that needs to be updated: https://github.com/search?q=repo%3Acube-js%2Fcube%20databricks-jdbc&type=code

[vincentditlevinz]

High @igorlukanin

I managed to add some tests with testcontainer that have worked on my laptop 😄 They test testConnection() and a simple query (count(*)) against an Arrow flight SQL compatible database.

When I compared all occurrences of databrick-jdbc with my PR I found that I haven't yet:

• written any doc.
• written anything in cubejs-testing/birdbox-fixture, not sure I should.
• written anything in cubejs-testing-drivers. It sounds a bit complex to me to understand what I should code there.
• Add a line in cubejs-docker/package.json, because it won't work until we first deploy flightsql-jdbc driver in the NPM repository (same for the CLI that won't work until this moment too). As far as I understand, a new driver can only be deployed in a "latest" docker image if it has been already deployed in the NPM repository.

The last item probably explains why my new driver doesn't work well in the playground, because I must use a "dev" docker image for the moment.

Please, let me know what you expect me to do to make this PR valid according to your development standards.

[vincentditlevinz]

I think I should remove these lines, they seem to be related to cubejs-testing-driver.