Skip to content

Conversation

MazterQyou
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR updates the parse_date_str shared function, adding the value that couldn't be parsed to the error message. This will aid in debugging date/time values that could not be parsed.

@MazterQyou MazterQyou requested a review from a team as a code owner September 11, 2025 16:03
@MazterQyou MazterQyou force-pushed the cubesql/print-datetime-parse-error-value branch from 6b091b6 to 9b0b740 Compare September 11, 2025 16:10
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.62%. Comparing base (b279611) to head (9b0b740).

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/compile/date_parser.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9961       +/-   ##
===========================================
+ Coverage        0   84.62%   +84.62%     
===========================================
  Files           0      253      +253     
  Lines           0    90049    +90049     
===========================================
+ Hits            0    76208    +76208     
- Misses          0    13841    +13841     
Flag Coverage Δ
cubesql 84.62% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants