Charts #6
Open
Charts #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is basically pull request #5 reopened with branch set to charts instead of master).
I've added chart support. It is written in a way that tries to be backend agnostic, so a user is not forced to use any particular packages. Instead the only thing reportengine demands from user is to provide callables that accept particular format of parameters and return objects suitable for rendering in selected output format(s) (which will usually mean duck typing). That way we are not tied to any specific chart backend and it should be quite easy to write wrappers for existing backends.
Chart configuration format probably needs rethinking; I'm not sure if it shouldn't be a bit simpler.
I've also made a Google Chart API wrapper (for new version of API released in April 2012) which is suitable for use with this set of commits: https://github.com/KrzysiekJ/gchart