[+] apply admin functions migrations for v5, fixes #1180#1181
Open
[+] apply admin functions migrations for v5, fixes #1180#1181
Conversation
for easier migration from v4.0.0 => v5.0.0
0xgouda
changed the title
0xgouda
commented
Feb 4, 2026
Comment on lines
+606
to
+617
| &migrator.Migration{ | ||
| Name: "01180 Apply admin functions migrations for v5", | ||
| Func: func(ctx context.Context, tx pgx.Tx) error { | ||
| _, err := tx.Exec(ctx, `DROP FUNCTION IF EXISTS admin.ensure_partition_metric_dbname_time`) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| _, err = tx.Exec(ctx, sqlMetricEnsurePartitionPostgres) | ||
| if err != nil { | ||
| return err | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Added DROP FUNCTION IF EXISTS admin.ensure_partition_metric_dbname_time for users migrating from v4.0.0 to v5, as in v4.1 we forgot to add the migration for that.
And it will be re-created with the v5 migration in script sqlMetricEnsurePartitionPostgres
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1180