Skip to content

Typecast support callable with arguments #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: 2.x
Choose a base branch
from

Conversation

puzzledpolymath
Copy link

🔍 What was changed

  • Added support for callable rules with arguments
  • Added test cases callable rules with arguments

🤔 Why?

Callable rules may require additional information. E.g. a behavior with attributes which need to be resolved during casting

📝 Checklist

  • How was this tested:
    • Tested manually
    • Unit tests added

@puzzledpolymath puzzledpolymath changed the title Callable with arguments Typecast support callable with arguments Aug 19, 2025
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 90.32258% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.58%. Comparing base (78009d9) to head (b1dea77).

Files with missing lines Patch % Lines
src/Parser/Typecast.php 90.16% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #529      +/-   ##
============================================
- Coverage     91.66%   91.58%   -0.09%     
- Complexity     1843     1850       +7     
============================================
  Files           118      118              
  Lines          4728     4740      +12     
============================================
+ Hits           4334     4341       +7     
- Misses          394      399       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roxblnfk
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants