-
Notifications
You must be signed in to change notification settings - Fork 18
adds dragonflyDb template #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ashish111333
wants to merge
21
commits into
cyclops-ui:main
Choose a base branch
from
ashish111333:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petar-cvit
requested changes
Aug 7, 2024
@petar-cvit removed values.schema.json |
petar-cvit
requested changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ashish111333 for the PR!
Make sure to run
helm template release-name .
from the dragonfly
directory to check the chart is rendering as expected. I'm currently getting the following error:
Error: values don't meet the specifications of the schema(s) in the following chart(s):
dragonfly:
- serviceMonitor: Invalid type. Expected: boolean, given: object
Can you check it out?
@petar-cvit fixed, can you review it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Description
adds dragonfly-DB template(made under quira.sh cyclops quest)
dragonfly-DB is a super fast memory datastore fully compatible with redis.
β Checks