fix(edge-worker): thread apiBaseUrl into GitLabCommentService for Self-Managed GitLab#1191
Open
tenfourty wants to merge 2 commits into
Open
fix(edge-worker): thread apiBaseUrl into GitLabCommentService for Self-Managed GitLab#1191tenfourty wants to merge 2 commits into
tenfourty wants to merge 2 commits into
Conversation
…f-Managed GitLab GitLabCommentService accepts an optional apiBaseUrl in its constructor but EdgeWorker was instantiating it with no args, leaving it pinned to the gitlab.com default. On Self-Managed instances every MR-reply request 404s. Derive apiBaseUrl from the URL origin of the first configured repo with a gitlabUrl. Single GitLab host per Cyrus instance — multi-host per-repo dispatch is out of scope.
tenfourty
force-pushed
the
feat/self-managed-apibaseurl
branch
from
ce20807 to
9d1f493
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitLabCommentServiceaccepts an optionalapiBaseUrlin its constructor, butEdgeWorkerwas instantiating it with no args. On a Self-Managed GitLab every MR-reply request was hittinggitlab.comand 404'ing — the only obvious signal was a steady stream of 404s in the logs.This derives
apiBaseUrlfrom the URL origin of the first configured repo with agitlabUrl. Single GitLab host per Cyrus instance — multi-host per-repo dispatch is out of scope here.Test plan
pnpm test:packages:run— all package tests passpnpm typecheck— cleanpnpm lint— clean on the changed filegitlab.com