fix(edge-worker): include autoMemoryDirectory in chat allowedDirectories (CYPACK-1197)#1206
Merged
Conversation
…ies (CYPACK-1197) The shared auto-memory directory (`<cyrusHome>/<platform>-memory/`) was set as the runner's `autoMemoryDirectory` but missing from `allowedDirectories`. `buildHomeDirectoryDisallowedTools` then emitted a Read deny rule for it, blocking the running session from reading or editing existing memory files (including MEMORY.md). Adding it to `allowedDirectories` lets the home-dir restriction helper treat it as a passthrough and surfaces the directory through the SDK `--add-dir` plumbing.
Connoropolous
approved these changes
May 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<cyrusHome>/<platform>-memory/) toallowedDirectoriesinRunnerConfigBuilder.buildChatConfigso chat sessions can read and edit existing memory files (not just append new ones via shell redirects).buildHomeDirectoryDisallowedToolsemitted aRead(...)deny rule for the memory directory, leaving the auto-memory feature half-working.Fixes CYPACK-1197.
Test plan
packages/edge-worker/test/RunnerConfigBuilder.chat-config.test.tsassertsautoMemoryDirectoryis inallowedDirectories.pnpm --filter cyrus-edge-worker test:run— 612 tests pass.pnpm --filter cyrus-edge-worker typecheck— clean.MEMORY.mdand verifyEditsucceeds without permission errors.