CORE-2103: Add min/max GPUs to edit tool dialog #645
Conversation
| maxDiskSpace={maxDiskSpace} | ||
| maxCPUCore={maxCPUCore} | ||
| maxMemory={maxMemory} | ||
| maxGPU={maxGPU} |
There was a problem hiding this comment.
This still needs to be destructred from props at the top of this EditToolForm component.
If this were a Typescript file, it probably would have been caught at compile-time 😖
|
|
||
| const gpu_limit = getIn(values, "container.max_gpus"); | ||
| if (gpu_limit > 0 && value > gpu_limit) { | ||
| return t("validationErrMinGpusGreaterThanMax"); |
There was a problem hiding this comment.
This i18n message needs to be added to public/static/locales/en/tools.json.
|
|
||
| const min_gpu_limit = getIn(values, "container.min_gpus"); | ||
| if (0 < value && value < min_gpu_limit) { | ||
| return t("validationErrMaxGpusLessThanMin"); |
There was a problem hiding this comment.
This i18n message needs to be added to public/static/locales/en/tools.json.
| {isAdmin && ( | ||
| <Field | ||
| name="container.min_gpus" | ||
| label={t("minGpus")} |
There was a problem hiding this comment.
This i18n message needs to be added to public/static/locales/en/tools.json.
| )} | ||
| <Field | ||
| name="container.max_gpus" | ||
| label={t("gpuLimit")} |
There was a problem hiding this comment.
This i18n message needs to be added to public/static/locales/en/tools.json.
|
Appreciate the reviews, I definitely put this up hastily and didn't check on it well enough. I'll work on getting those strings in and the destructuring issue fixed. |
… missed in tool details
ianmcorvidae
changed the title
|
thanks for the re-review! I think I'll go ahead and merge this and get it deployed in QA to make sure regular job launches still work, then get working more deeply on the user-facing bits |
3 participants
Putting this up now. I need to test it a bit more and of course there's the user-facing side to do as well, but it's the last day before break anyway, so I may as well put what I have up.