feat: allow for a kubernetes endpoint resolver #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
relates to #129 |
|
Looks good so far. I am not against a breaking change in 1.2.x. But if we do and get rid of the temporary solution we needed to this time, i would strongly argue to use a more structured config path. I have something like this in mind. In my opinion it is not clear that everything else than host are labels. If we do the breaking change with a custom unmarshaller, i would suggest something like in k8s. targets:
- host: google.com
labels:
my_label: my_valueThis would also allow extensibility if we want to add something host specific beside labels in the future What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #130