fix: preserve raw input in typed fields during editing#34
Merged
d12frosted merged 2 commits intomasterfrom Jan 25, 2026
Merged
Conversation
Base automatically changed from
feat/extensions-validation
to
feat/must-exist-validation
January 25, 2026 21:16
ff219e8 to
bb1e1b4
Compare
Allows specifying allowed file extensions, e.g., :extensions '("el" "org").
Error message shows allowed extensions when validation fails.
Previously, typed fields would replace user input with parsed values when the parent component re-rendered. For example, typing "12.8" and backspacing to "12." would show "12" instead of "12." because the parsed integer value was synced back to the display. The fix introduces a two-pronged approach in on-update: - Track last-prop-value: the last value synced FROM parent props - Track synced-value: the last typed value from user input Only sync raw-value when the change is truly external (prop changed AND doesn't match user's typed value). This preserves raw input like "12." or "~/data.el" while still allowing external value updates. Also adds debug logging (enabled via vui-debug) for troubleshooting typed field state changes.
0c3cf19 to
c847aa0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vui-debug) for troubleshooting typed field state