π‘οΈ Sentinel: [CRITICAL] Fix SSRF in APRS Poller TCP Connection#96
π‘οΈ Sentinel: [CRITICAL] Fix SSRF in APRS Poller TCP Connection#96d3mocide wants to merge 1 commit into
Conversation
Adds `validate_safe_host(host)` validation before calling `asyncio.open_connection()` in poller scripts to prevent Server-Side Request Forgery vulnerabilities when establishing TCP connections. Also updates the .jules/sentinel.md security journal. Co-authored-by: d3mocide <136547209+d3mocide@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: SSRF was possible via the
asyncio.open_connection(host, port)calls in the APRS poller (fetching config from thepoller_sourcesDB table) and in the Beast and CoT receivers. An attacker with admin privileges could manipulate the configuration to probe and connect to arbitrary internal/private services on the backend network via the poller container.π― Impact: This allowed connection to internal ports/services which could bypass firewalls, conduct network scans, or interact with unauthenticated internal applications.
π§ Fix: Imported and invoked the centralized
validate_safe_hostmethod to ensure the target host resolves to a safe, public IP before initiating the socket connection.β Verification: Ran the full backend and poller test suites to verify no breaking changes were introduced and code compiles successfully.
PR created automatically by Jules for task 5105308995645511795 started by @d3mocide