Skip to content

ci: add CLI test workflow#1242

Open
junghyeonsu wants to merge 7 commits intodevfrom
ci/cli-test-workflow
Open

ci: add CLI test workflow#1242
junghyeonsu wants to merge 7 commits intodevfrom
ci/cli-test-workflow

Conversation

@junghyeonsu
Copy link
Contributor

@junghyeonsu junghyeonsu commented Feb 13, 2026

Summary

  • add a dedicated GitHub Actions workflow for CLI tests
  • trigger workflow when files in packages/cli change
  • run bun install and bun test packages/cli in CI

Validation

  • bun test packages/cli

Summary by CodeRabbit

  • 작업
    • CI에 새 "CLI 테스트" 자동화 워크플로우를 추가하여 관련 변경 시 CLI 테스트가 자동 실행되도록 구성함.
  • 테스트
    • 기존 CLI 테스트의 사례 설명과 인라인 주석을 한국어로 번역하여 가독성과 로컬화 향상(테스트 로직 및 기대 동작 불변).
  • 정리
    • 여러 배포/테스트 워크플로우에서 자동 환경 토큰 주입을 제거하여 런너 환경의 민감 정보 노출을 축소함.

@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2026

⚠️ No Changeset found

Latest commit: c6be27f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

.github/workflows/cli-test.yml 워크플로우가 새로 추가되어 packages/cli 관련 푸시를 감지하고 로컬 setup 액션 실행 후 bun test packages/cli를 실행합니다. 다수의 기존 워크플로우에서 env: GITHUB_TOKEN 선언이 제거되었고, packages/cli/src/tests/resolve-dependencies.test.ts의 테스트 설명이 한국어로 번역되었습니다.

Changes

Cohort / File(s) Summary
새 워크플로우 추가
.github/workflows/cli-test.yml
새 "Test CLI" 워크플로우 추가: packages/cli/**/* 푸시 트리거, GITHUB_TOKEN을 시크릿에서 설정, contents: read 권한, test job에서 actions/checkout@v6, 로컬 액션 ./.github/actions/setup, bun test packages/cli 실행.
워크플로우: GITHUB_TOKEN 제거/포맷 조정
.github/workflows/deploy-seed-design-docs-alpha-pages.yml, .github/workflows/deploy-seed-design-docs-prod-pages.yml, .github/workflows/deploy-seed-design-stackflow-spa-alpha-pages.yml, .github/workflows/deploy-seed-design-stackflow-spa-prod-pages.yml, .github/workflows/deploy-seed-design-storybook-alpha-pages.yml, .github/workflows/deploy-seed-design-storybook-prod-pages.yml, .github/workflows/llms-transform-test.yml, .github/workflows/react-headless-test.yml, .github/workflows/react-test.yml, .github/workflows/release-packages.yml, .github/workflows/rootage-core-test.yml
여러 워크플로우에서 최상단/글로벌 env: GITHUB_TOKEN 선언 제거 및 몇몇 파일의 사소한 포맷(줄바꿈) 조정. 워크플로우 로직·권한(예: contents: read) 및 스텝은 변경 없음.
테스트 설명 번역
packages/cli/src/tests/resolve-dependencies.test.ts
테스트 케이스 제목 및 일부 주석을 영어에서 한국어로 번역. 테스트 구현과 기대값은 변경 없음.

Sequence Diagram(s)

(생략)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 깡충깡충 CI 길을 달려
로컬 액션 잡고 체크아웃했네
번으로 테스트 콸콸 돌리고
한국말 이름 속에 사례들이 반짝
당근 한 입, 커밋엔 평화가 있지 🥕

🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive 제목이 주요 변경 사항인 CLI 테스트 워크플로우 추가를 명확하게 설명하고 있으나, 동시에 여러 기존 워크플로우에서 GITHUB_TOKEN을 제거한 상당한 변경 사항을 누락하고 있습니다. 제목이 모호할 수 있으므로 PR의 범위를 더 명확히 하는 것이 좋습니다. 예를 들어 'ci: add CLI test workflow and remove unused GITHUB_TOKEN' 또는 두 부분을 분리된 PR로 나누는 것을 고려하세요.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into dev

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/cli-test-workflow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.github/workflows/cli-test.yml:
- Around line 9-10: Remove the unnecessary GITHUB_TOKEN environment variable
from the CLI test workflow: delete the env entry setting GITHUB_TOKEN (the line
with "GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}") in
.github/workflows/cli-test.yml so the job no longer exposes that secret; confirm
there are no usages of github.token or process.env.GITHUB* in packages/cli test
code (packages/cli) before committing and ensure the workflow still runs the
existing step that executes "bun test packages/cli".
🧹 Nitpick comments (1)
.github/workflows/cli-test.yml (1)

3-7: pull_request 트리거 추가를 고려해주세요.

현재 push 이벤트에서만 트리거되므로, PR 머지 전에는 테스트가 실행되지 않습니다. PR 단계에서 CLI 코드 변경의 회귀를 사전에 감지하려면 pull_request 트리거도 함께 추가하는 것이 좋습니다.

♻️ 제안 diff
 on:
   push:
     paths:
       - "packages/cli/**/*"
       - ".github/workflows/cli-test.yml"
+  pull_request:
+    paths:
+      - "packages/cli/**/*"
+      - ".github/workflows/cli-test.yml"

@junghyeonsu junghyeonsu self-assigned this Feb 13, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2026

Alpha Preview (Stackflow SPA)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2026

Alpha Preview (Storybook)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2026

Alpha Preview (Docs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant