Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
There was a problem hiding this comment.
I think it would be better to separate it from the type-check job. How about creating a new job called changeset?
# as-is
jobs:
type-check:
# do typescript type check and changeset ci
# to-be
jobs:
type-check:
# do only typescript type check
changeset:
# do only changeset ci
That's right. but this might be creating a lot of duplicated steps that are hard to maintain. Let's move on after #553 merged. Note: I considered composite action containing shared steps(setup node, cache, yarn install) but post-if for conditional cache save is not supported yet. |
466af30 to
ae59457
Compare
This reverts commit 169473a.
Adding the changeset is now mandatory for Pull Requests.
Use
changeset add --emptyif you want to avoid versioning.