feat(react): Add ActivityComponentType paramterized by params#636
feat(react): Add ActivityComponentType paramterized by params#636ENvironmentSet merged 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 07a05b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughAdds a changeset entry for a minor release of @stackflow/react and introduces a new public type export alias Changes
Sequence Diagram(s)(omitted — changes are limited to a type export alias and a changeset entry; no control-flow changes) Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
stackflow-docs | 07a05b1 | Commit Preview URL | Oct 16 2025, 08:45 AM |
Deploying stackflow-demo with
|
| Latest commit: |
07a05b1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://07f51d85.stackflow-demo.pages.dev |
| Branch Preview URL: | https://activitycomponenttypebyparam.stackflow-demo.pages.dev |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.changeset/dry-olives-take.md(1 hunks)integrations/react/src/future/index.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Write source in TypeScript with strict typing enabled across the codebase
Files:
integrations/react/src/future/index.ts
.changeset/*.md
📄 CodeRabbit inference engine (AGENTS.md)
Include a Changeset entry for any user-facing package change
Files:
.changeset/dry-olives-take.md
🔇 Additional comments (1)
integrations/react/src/future/index.ts (1)
1-1: Verify the intent of exposing the internal API.This line exports
ActivityComponentTypefrom../__internal__/ActivityComponentTypeasActivityComponentTypeByParams, while line 7 exports from./ActivityComponentType. Please clarify:
- Are these two exports referencing the same type or different implementations?
- Is exposing the
__internal__path intentional for this public API?- Should
ActivityComponentTypeByParamseventually replace the export on line 7, or are they meant to coexist?Run the following script to verify the relationship between these two exports:
| "@stackflow/react": minor | ||
| --- | ||
|
|
||
| Add ActivityComponentType paramterized by params |
There was a problem hiding this comment.
Fix the typo in the changeset description.
The word "paramterized" should be "parameterized".
Apply this diff to fix the typo:
-Add ActivityComponentType paramterized by params
+Add ActivityComponentType parameterized by params📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Add ActivityComponentType paramterized by params | |
| Add ActivityComponentType parameterized by params |
🤖 Prompt for AI Agents
In .changeset/dry-olives-take.md around line 5, fix the typo in the changeset
description by replacing "paramterized" with the correct spelling
"parameterized" so the line reads: "Add ActivityComponentType parameterized by
params".
commit: |
No description provided.