Add EdwardsPoint::from_affine (const)
#819
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying field elements are unsafe for public consumption as they have undefined arithmetic after a certain amount of uses. This trait solves the problem as following: - Defining a `ff::Field` wrapper which reduces after _every operation_ - Defining a bespoke `LazyField` trait which tracks consumed capacity using `typenum` - Definining a wrapper so any existing `ff::Field` may satisfy `LazyField` (actually allowing the `LazyField` trait to be considered for usage) - Defining a marker trait for any lazy field with a certain amount of capacity, so code generic to the field may still reduce how often they perform modular reductions - Implementing `LazyField` for `FieldElement`
…`LazyField` trait Adds a simple wrapper which stops dependents from accessing the underlying type.
All always return reduced outputs for all four backends present within curve25519-dalek. This may be an unnecessary design choice of the backends, offering potential future improvements, yet it's one we can take advantage of here.
kayabaNerve
force-pushed
the
from_affine
branch
from
fec15eb to
2afa35c
Compare
tarcieri
reviewed
Sep 3, 2025
Restores bound of `3` for 32-bit platforms.
kayabaNerve
force-pushed
the
from_affine
branch
from
08e2732 to
938d11b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #816. Resolves #817.