Skip to content

refactor: optimize code based on cargo fmt #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: optimize code based on cargo fmt #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 87 additions & 17 deletions tests/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,16 +290,66 @@ fn test_ctoption() {
));

// Test (in)equality
assert!(CtOption::new(1, Choice::from(0)).ct_eq(&CtOption::new(1, Choice::from(1))).unwrap_u8() == 0);
assert!(CtOption::new(1, Choice::from(1)).ct_eq(&CtOption::new(1, Choice::from(0))).unwrap_u8() == 0);
assert!(CtOption::new(1, Choice::from(0)).ct_eq(&CtOption::new(2, Choice::from(1))).unwrap_u8() == 0);
assert!(CtOption::new(1, Choice::from(1)).ct_eq(&CtOption::new(2, Choice::from(0))).unwrap_u8() == 0);
assert!(CtOption::new(1, Choice::from(0)).ct_eq(&CtOption::new(1, Choice::from(0))).unwrap_u8() == 1);
assert!(CtOption::new(1, Choice::from(0)).ct_eq(&CtOption::new(2, Choice::from(0))).unwrap_u8() == 1);
assert!(CtOption::new(1, Choice::from(1)).ct_eq(&CtOption::new(2, Choice::from(1))).unwrap_u8() == 0);
assert!(CtOption::new(1, Choice::from(1)).ct_eq(&CtOption::new(2, Choice::from(1))).unwrap_u8() == 0);
assert!(CtOption::new(1, Choice::from(1)).ct_eq(&CtOption::new(1, Choice::from(1))).unwrap_u8() == 1);
assert!(CtOption::new(1, Choice::from(1)).ct_eq(&CtOption::new(1, Choice::from(1))).unwrap_u8() == 1);
assert!(
CtOption::new(1, Choice::from(0))
.ct_eq(&CtOption::new(1, Choice::from(1)))
.unwrap_u8()
== 0
);
assert!(
CtOption::new(1, Choice::from(1))
.ct_eq(&CtOption::new(1, Choice::from(0)))
.unwrap_u8()
== 0
);
assert!(
CtOption::new(1, Choice::from(0))
.ct_eq(&CtOption::new(2, Choice::from(1)))
.unwrap_u8()
== 0
);
assert!(
CtOption::new(1, Choice::from(1))
.ct_eq(&CtOption::new(2, Choice::from(0)))
.unwrap_u8()
== 0
);
assert!(
CtOption::new(1, Choice::from(0))
.ct_eq(&CtOption::new(1, Choice::from(0)))
.unwrap_u8()
== 1
);
assert!(
CtOption::new(1, Choice::from(0))
.ct_eq(&CtOption::new(2, Choice::from(0)))
.unwrap_u8()
== 1
);
assert!(
CtOption::new(1, Choice::from(1))
.ct_eq(&CtOption::new(2, Choice::from(1)))
.unwrap_u8()
== 0
);
assert!(
CtOption::new(1, Choice::from(1))
.ct_eq(&CtOption::new(2, Choice::from(1)))
.unwrap_u8()
== 0
);
assert!(
CtOption::new(1, Choice::from(1))
.ct_eq(&CtOption::new(1, Choice::from(1)))
.unwrap_u8()
== 1
);
assert!(
CtOption::new(1, Choice::from(1))
.ct_eq(&CtOption::new(1, Choice::from(1)))
.unwrap_u8()
== 1
);
}

#[test]
Expand Down Expand Up @@ -327,7 +377,7 @@ macro_rules! generate_greater_than_test {
assert!(z.unwrap_u8() == 1);
}
}
}
};
}

#[test]
Expand Down Expand Up @@ -358,16 +408,26 @@ fn greater_than_u128() {

#[test]
fn greater_than_ordering() {
assert_eq!(cmp::Ordering::Less.ct_gt(&cmp::Ordering::Greater).unwrap_u8(), 0);
assert_eq!(cmp::Ordering::Greater.ct_gt(&cmp::Ordering::Less).unwrap_u8(), 1);
assert_eq!(
cmp::Ordering::Less
.ct_gt(&cmp::Ordering::Greater)
.unwrap_u8(),
0
);
assert_eq!(
cmp::Ordering::Greater
.ct_gt(&cmp::Ordering::Less)
.unwrap_u8(),
1
);
}

#[test]
/// Test that the two's compliment min and max, i.e. 0000...0001 < 1111...1110,
/// gives the correct result. (This fails using the bit-twiddling algorithm that
/// go/crypto/subtle uses.)
fn less_than_twos_compliment_minmax() {
let z = 1u32.ct_lt(&(2u32.pow(31)-1));
let z = 1u32.ct_lt(&(2u32.pow(31) - 1));

assert!(z.unwrap_u8() == 1);
}
Expand All @@ -389,7 +449,7 @@ macro_rules! generate_less_than_test {
assert!(z.unwrap_u8() == 1);
}
}
}
};
}

#[test]
Expand Down Expand Up @@ -420,8 +480,18 @@ fn less_than_u128() {

#[test]
fn less_than_ordering() {
assert_eq!(cmp::Ordering::Greater.ct_lt(&cmp::Ordering::Less).unwrap_u8(), 0);
assert_eq!(cmp::Ordering::Less.ct_lt(&cmp::Ordering::Greater).unwrap_u8(), 1);
assert_eq!(
cmp::Ordering::Greater
.ct_lt(&cmp::Ordering::Less)
.unwrap_u8(),
0
);
assert_eq!(
cmp::Ordering::Less
.ct_lt(&cmp::Ordering::Greater)
.unwrap_u8(),
1
);
}

#[test]
Expand Down