Skip to content

Conversation

@asmacdo
Copy link
Member

@asmacdo asmacdo commented Mar 20, 2025

#2184

  • Restrict to admins
  • Improve Response
  • Find a way to test
  • Allow emails to multiple users?
  • Issue mentioned "From:" but build_message does not support-- ok to just send from the admin email?
  • Add option for html or plaintext

@jjnesbitt
Copy link
Member

jjnesbitt commented Mar 20, 2025

What is the point of having this exposed as an API endpoint? Why not expose this through the admin interface, as a custom dashboard perhaps? Having an endpoint that sends one email to one user seems both over-engineered, as well as lacking in usability.

@yarikoptic
Copy link
Member

We have a number of possible types of notifications and inquiries etc to be sent to dandiset owners re hub status, dandiset bugs, etc. So we need some centralized means to achieve that, potentially without requiring development of custom and fixed email template within dandi-archive (in a dashboard or not), but rather just utilizing its already existing ability to send such an email so we could interface such monitoring etc tools to that.

name='upload-validate',
),
path('api/users/me/', users_me_view),
path('api/users/mail/', user_email_view),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and may be later

/dandisets/{dandiset__pk}/mail/

to target corresponding author of the dandiset without requiring custom code to figure out who that is. Then that endpoint would first figure out corresponding author(s) and build the to and potentially even subject prefix.

@asmacdo
Copy link
Member Author

asmacdo commented Nov 7, 2025

I'll close since this isnt making progress. (It was previously decided to open a design doc PR #2370 which is also stuck) This could be useful as a reference, but its simple enough its probably not worth trying to directly apply these commits to modern dandi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants