Conversation
fbartho
requested changes
Jan 6, 2022
Member
fbartho
left a comment
fbartho
left a comment
There was a problem hiding this comment.
What's the "purpose" of this change? Is it just a flakiness/performance optimization? or is it something more?
No objections conceptually, so once it's green I'm happy to re-review for you!
|
|
||
| exec(call, (err, stdout, _stderr) => { | ||
| if (err) { | ||
| console.error(`Could not get the git HEAD for the current path]`) |
Member
There was a problem hiding this comment.
Suggested change
| console.error(`Could not get the git HEAD for the current path]`) | |
| console.error(`Could not get the git HEAD for the current path`) |
|
|
||
| export const localGetHeadSHA = () => | ||
| new Promise<string>(done => { | ||
| const call = `git rev-parse HEAD"` |
Member
There was a problem hiding this comment.
Suggested change
| const call = `git rev-parse HEAD"` | |
| const call = `git rev-parse HEAD` |
This typo looks like it might be the first level of why the PR was red 🟥
Comment on lines
+62
to
+97
| // expect(rangesOfDifferBetweenTwoStrings(src, target)).toMatchInlineSnapshot(` | ||
| // Array [ | ||
| // Object { | ||
| // "length": 1, | ||
| // "start": 6, | ||
| // }, | ||
| // ] | ||
| // `) | ||
|
|
||
| // const multilineInput = ` | ||
| // ↓ | ||
| // (↓ | ||
| // ····<div>↓ | ||
| // ······text↓ | ||
| // ····</div>↓ | ||
| // ) | ||
| // ` | ||
| // const multilineOutput = ` | ||
| // ↓ | ||
| // (↓ | ||
| // ····<div>↓ | ||
| // ········text↓ | ||
| // ······</div>↓ | ||
| // )` | ||
| // expect(rangesOfDifferBetweenTwoStrings(multilineInput, multilineOutput)).toMatchInlineSnapshot(` | ||
| // Array [ | ||
| // Object { | ||
| // "length": 8, | ||
| // "start": 22, | ||
| // }, | ||
| // Object { | ||
| // "length": 10, | ||
| // "start": 32, | ||
| // }, | ||
| // ] | ||
| // `) |
Member
There was a problem hiding this comment.
Suggested change
| // expect(rangesOfDifferBetweenTwoStrings(src, target)).toMatchInlineSnapshot(` | |
| // Array [ | |
| // Object { | |
| // "length": 1, | |
| // "start": 6, | |
| // }, | |
| // ] | |
| // `) | |
| // const multilineInput = ` | |
| // ↓ | |
| // (↓ | |
| // ····<div>↓ | |
| // ······text↓ | |
| // ····</div>↓ | |
| // ) | |
| // ` | |
| // const multilineOutput = ` | |
| // ↓ | |
| // (↓ | |
| // ····<div>↓ | |
| // ········text↓ | |
| // ······</div>↓ | |
| // )` | |
| // expect(rangesOfDifferBetweenTwoStrings(multilineInput, multilineOutput)).toMatchInlineSnapshot(` | |
| // Array [ | |
| // Object { | |
| // "length": 8, | |
| // "start": 22, | |
| // }, | |
| // Object { | |
| // "length": 10, | |
| // "start": 32, | |
| // }, | |
| // ] | |
| // `) |
Not sure if this was a copy-pasted test file, or if you actually want these tests to work?
Member
Author
|
Perf, people check huge amounts of files and that can hit the GH API limits |
PR Suggestions for #991
|
Can you finish this, please? |
|
Member
Author
|
It's OSS people, feel free to take over the PR instead of asking for folks to do volunteer work for you 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't have time to make it green, but maybe this could work