Use GitLab project ID instead of project name#994
Use GitLab project ID instead of project name#994farabi wants to merge 4 commits intodanger:mainfrom
Conversation
Use gitlab project id. when not defined. use project name instead. Add doc about gitlab project id. Update gitlabApi unit tests, and repo slug documentation.
| const nockBack = nock.back | ||
| nockBack.fixtures = __dirname + "/fixtures" | ||
|
|
||
| // We're testing https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/27117 |
There was a problem hiding this comment.
This change dories me a bit, because this link used to work - but now it doesn't?
There was a problem hiding this comment.
The repo was moved to gitlab-foss. New MR link: https://gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/27117
I updated the tests and fixtures for all Gitlab tests in #1002
There was a problem hiding this comment.
Also I think tests should run for both projectId and project path
There was a problem hiding this comment.
the link change should be reverted because https://gitlab.com/456/merge_requests/27117 is 404
or updated to the redirected link.
this is just a comment, the code can continue use numeric id
Minor update to documentation comment following review. Co-Authored-By: Orta <orta.therox+github@gmail.com>
|
Why undo the project will to project may change? |
|
@orta |
|
I think this might have been done in #1002 too 👍 |
|
Hi! I'm just getting started with Danger... on gitlab.com :( Is there a summary of what's blocking this PR? or anything I can do to help? |
|
Can we not to support ID and project name as Gitlab actually does? |
8 participants
#969 Here i added an environment variable for gitlab project id called DANGER_GITLAB_PROJECT_ID
Also added some doc about that. and updated GitlabAPI unit tests.
Project name will be used if project ID is not defined (so no breaking changes).