feat: ignore scheduler and placement connect #1528
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gallardot <[email protected]>
yaron2
requested changes
Aug 13, 2025
| @@ -129,6 +129,11 @@ func (config *RunConfig) validatePlacementHostAddr() error { | |||
| if len(placementHostAddr) == 0 { | |||
| placementHostAddr = "localhost" | |||
| } | |||
|
|
|||
| if strings.TrimSpace(placementHostAddr) == "" { | |||
There was a problem hiding this comment.
"localhost" is being assigned above in line 130 if placementHostAddr is empty, so this check could never be true
There was a problem hiding this comment.
"localhost" is being assigned above in line 130 if placementHostAddr is empty, so this check could never be true
Hi @yaron2 , Thanks for your reply.
Here is an example:
dapr run --placement-host-address " " --scheduler-host-address " " -a app-id
This is different from "empty". The part I modified is to handle such cases. I think it is OK.
When using the CLI, ensure that the provided capabilities are consistent with those of the annotations.
Comma separated list of addresses for Dapr Actor Placement servers.
When no annotation is set, the default value is set by the Sidecar Injector.
When the annotation is set and the value is a single space (' '), or “empty”, the sidecar does not connect to Placement server. This can be used when there are no actors running in the sidecar.
When the annotation is set and the value is not empty, the sidecar connects to the configured address. For example: 127.0.0.1:50057,127.0.0.1:50058
For reference, please see:
https://docs.dapr.io/reference/arguments-annotations-overview/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you've made
Issue reference
#1503
https://docs.dapr.io/reference/arguments-annotations-overview/
Sometimes when developing locally, we don't need placement and scheduler.
When using cli, provide capabilities consistent with annotation.
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: