Skip to content

Conversation

pnagaraj80
Copy link
Contributor

@pnagaraj80 pnagaraj80 commented Jun 20, 2025

Description

This PR adds support for the replicateSubscriptionState flag in the Pulsar pubsub component, which enables replication of subscription state across different Pulsar clusters in a geo-replicated setup.

Changes:

  • Added ReplicateSubscriptionState field to pulsarMetadata struct
  • Updated Subscribe method to use ReplicateSubscriptionState in ConsumerOptions
  • Added comprehensive tests for the new functionality

Fixes the missing support for subscription state replication in multi-cluster Pulsar deployments.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR addresses: #3854

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

…ponent

This commit adds support for the replicateSubscriptionState flag in the Pulsar
pubsub component, which enables replication of subscription state across
different Pulsar clusters in a geo-replicated setup.

Changes:
- Added ReplicateSubscriptionState field to pulsarMetadata struct
- Updated Subscribe method to use ReplicateSubscriptionState in ConsumerOptions
- Added comprehensive tests for the new functionality

Fixes the missing support for subscription state replication in multi-cluster
Pulsar deployments.

Signed-off-by: Prashanth Nagaraj <[email protected]>
@pnagaraj80 pnagaraj80 requested review from a team as code owners June 20, 2025 17:16
Signed-off-by: Prashanth Nagaraj <[email protected]>
@pnagaraj80 pnagaraj80 force-pushed the feat/pulsar-replicate-subscription-state branch from c49d5af to 2d75927 Compare June 20, 2025 18:23
@cicoyle cicoyle added the documentation required This issue needs documentation label Jun 25, 2025
@cicoyle
Copy link
Contributor

cicoyle commented Jun 25, 2025

Hey @pnagaraj80 - mind opening a dapr/docs PR adding your new field replicateSubscriptionState to the docs targeting the 1.16 branch?

cicoyle
cicoyle previously approved these changes Jun 25, 2025
@cicoyle cicoyle added the autoupdate automatically keeps PR up to date against master label Jun 25, 2025
@yaron2
Copy link
Member

yaron2 commented Jun 26, 2025

@pnagaraj80 please resolve the conflicts and we can then merge

@pnagaraj80
Copy link
Contributor Author

@pnagaraj80 please resolve the conflicts and we can then merge

Done @yaron2. Thanks.

@pnagaraj80
Copy link
Contributor Author

Hey @pnagaraj80 - mind opening a dapr/docs PR adding your new field replicateSubscriptionState to the docs targeting the 1.16 branch?

Done @cicoyle. Thanks.

@pnagaraj80 pnagaraj80 requested a review from cicoyle June 26, 2025 16:47
@yaron2 yaron2 enabled auto-merge August 1, 2025 16:24
@yaron2 yaron2 added this pull request to the merge queue Aug 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2025
@yaron2 yaron2 merged commit 7e34cc7 into dapr:main Aug 1, 2025
90 checks passed
@yaron2 yaron2 added this to the v1.16 milestone Aug 1, 2025
swatimodi-scout pushed a commit to swatimodi-scout/components-contrib that referenced this pull request Aug 19, 2025
…ponent (dapr#3853)

Signed-off-by: Prashanth Nagaraj <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Co-authored-by: Dapr Bot <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
jjcollinge pushed a commit to jjcollinge/components-contrib that referenced this pull request Aug 21, 2025
…ponent (dapr#3853)

Signed-off-by: Prashanth Nagaraj <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Co-authored-by: Dapr Bot <[email protected]>
@pnagaraj80 pnagaraj80 deleted the feat/pulsar-replicate-subscription-state branch August 25, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoupdate automatically keeps PR up to date against master documentation required This issue needs documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants