Skip to content

Conversation

@ManuInNZ
Copy link
Contributor

Signed-off-by: Emmanuel Auffray [email protected]

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs. N/A
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Just adding the doncs for the Google AI conversation models invocation.

Issue reference

N/A

@ManuInNZ ManuInNZ requested review from a team as code owners April 12, 2025 00:07
@ManuInNZ
Copy link
Contributor Author

@cicoyle ready for when the dapr/dapr#8572 is finished.

Based on 1.16 s requested my @msfussell

@ManuInNZ
Copy link
Contributor Author

created #4611

@msfussell
Copy link
Member

@ManuInNZ - Looks good. Also need to add this component and the Ollama one to this file https://github.com/dapr/docs/blob/v1.15/daprdocs/data/components/conversation/generic.yaml so these appear in the table https://docs.dapr.io/reference/components-reference/supported-conversation/.

@msfussell msfussell added this to the 1.16 milestone Apr 12, 2025
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, once you have added the index file for both

@ManuInNZ
Copy link
Contributor Author

Done but I guess this one is still pending closing the PR on dapr itself.

@msfussell msfussell added the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Apr 13, 2025
@ManuInNZ
Copy link
Contributor Author

@msfussell code pr merged by @yaron2
dapr/dapr@b365574
should be good to go
Thanks guys

@ManuInNZ
Copy link
Contributor Author

Just confirming code was merged

@ManuInNZ
Copy link
Contributor Author

ManuInNZ commented Apr 29, 2025

Bump @cicoyle @msfussell

@yaron2 yaron2 merged commit 52bd01f into dapr:v1.16 May 3, 2025
4 checks passed
@marcduiker
Copy link
Contributor

@holopin-bot @ManuInNZ Thank you! Here's a digital badge as a small token of appreciation.

@holopin-bot
Copy link

holopin-bot bot commented Jun 11, 2025

Congratulations @ManuInNZ, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmbrzfa42317207lauqzxyp8a

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-on-code-pr The code PR needs to be merged before the docs are updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants