-
Notifications
You must be signed in to change notification settings - Fork 767
Feature/converstion/googleai/1.16 #4611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Emmanuel Auffray <[email protected]>
@cicoyle ready for when the dapr/dapr#8572 is finished. Based on 1.16 s requested my @msfussell |
created #4611 |
@ManuInNZ - Looks good. Also need to add this component and the Ollama one to this file https://github.com/dapr/docs/blob/v1.15/daprdocs/data/components/conversation/generic.yaml so these appear in the table https://docs.dapr.io/reference/components-reference/supported-conversation/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, once you have added the index file for both
Signed-off-by: Emmanuel Auffray <[email protected]>
Done but I guess this one is still pending closing the PR on dapr itself. |
Signed-off-by: Emmanuel Auffray <[email protected]>
@msfussell code pr merged by @yaron2 |
Just confirming code was merged |
Bump @cicoyle @msfussell |
@holopin-bot @ManuInNZ Thank you! Here's a digital badge as a small token of appreciation. |
Congratulations @ManuInNZ, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmbrzfa42317207lauqzxyp8a This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Signed-off-by: Emmanuel Auffray [email protected]
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Just adding the doncs for the Google AI conversation models invocation.
Issue reference
N/A